Skip to content

Cache the methods in an element #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmdietl merged 3 commits into from
Apr 21, 2026
+21 −3
Merged

Cache the methods in an element #1645

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81e637b
Cache the methods in an element
wmdietl Apr 21, 2026
0363afb
Report CI timing comparison
Copilot Apr 21, 2026
ec48c4c
Remove accidental gradle dry-run metadata file
Copilot Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions framework/src/main/java/org/checkerframework/framework/stub/AnnotationFileParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2407,6 +2407,25 @@ private void processFakeOverride(
return findFieldElement(typeElt, enumConstName, astNode);
}

/** Cache all the methods that are in a TypeElement. */
private final Map<TypeElement, List<ExecutableElement>> methodsInTypeElementCache =
CollectionsPlume.createLruCache(100);

/**
* Determine all the methods that are in a TypeElement, caching the result.
*
* @param typeElt the type element
* @return the methods in that type element
*/
private List<ExecutableElement> methodsInTypeElement(TypeElement typeElt) {
List<ExecutableElement> res = methodsInTypeElementCache.get(typeElt);
if (res == null) {
res = ElementFilter.methodsIn(typeElt.getEnclosedElements());
methodsInTypeElementCache.put(typeElt, res);
}
return res;
}

/**
* Looks for a method element in {@code typeElt} that has the same name and formal parameter
* types as {@code methodDecl}. Returns null, and possibly issues a warning, if no such method
Expand All @@ -2428,7 +2447,7 @@ private void processFakeOverride(
int wantedMethodParams =
(methodDecl.getParameters() == null) ? 0 : methodDecl.getParameters().size();
String wantedMethodString = AnnotationFileUtil.toString(methodDecl);
for (ExecutableElement method : ElementFilter.methodsIn(typeElt.getEnclosedElements())) {
for (ExecutableElement method : methodsInTypeElement(typeElt)) {
if (wantedMethodParams == method.getParameters().size()
&& wantedMethodName.contentEquals(method.getSimpleName().toString())
&& ElementUtils.getSimpleSignature(method).equals(wantedMethodString)) {
Expand All @@ -2455,8 +2474,7 @@ private void processFakeOverride(
"method " + wantedMethodString + " not found in type " + typeElt);
if (debugAnnotationFileParser) {
stubDebug(" methods of %s:", typeElt);
for (ExecutableElement method :
ElementFilter.methodsIn(typeElt.getEnclosedElements())) {
for (ExecutableElement method : methodsInTypeElement(typeElt)) {
stubDebug(" %s", method);
}
}
Expand Down
Loading