fix(monero-wallet-ng): nested retry in sweep#1085
Conversation
1374ca9 to
950658c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 950658c. Configure here.
| let status = with_retry(inner_retry.clone(), "Sweep transaction-status lookup", || { | ||
| async { provider.transaction_status(tx_id).await } | ||
| }) | ||
| .await?; |
There was a problem hiding this comment.
Retry budget starts too early
Medium Severity
When construct_sweep_tx_to uses inner_retry with max_elapsed_time, that limit is measured from when the caller built the backoff, not from the sweep’s RPC steps. Work before the first with_retry (for example rpc_client().await in construct_sweep_to) and local scanning between steps still advance the same elapsed clock, so daemon retries can stop early even though the 45s budget was meant for those requests.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 950658c. Configure here.


No description provided.