Skip to content

fix(monero-wallet-ng): nested retry in sweep#1085

Merged
binarybaron merged 1 commit into
masterfrom
fix/monero-wallet-ng-sweep-nested-retry
Jun 8, 2026
Merged

fix(monero-wallet-ng): nested retry in sweep#1085
binarybaron merged 1 commit into
masterfrom
fix/monero-wallet-ng-sweep-nested-retry

Conversation

@binarybaron
Copy link
Copy Markdown

No description provided.

@binarybaron binarybaron force-pushed the fix/monero-wallet-ng-sweep-nested-retry branch from 1374ca9 to 950658c Compare June 8, 2026 12:45
@binarybaron binarybaron merged commit e5834c4 into master Jun 8, 2026
65 of 76 checks passed
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 950658c. Configure here.

let status = with_retry(inner_retry.clone(), "Sweep transaction-status lookup", || {
async { provider.transaction_status(tx_id).await }
})
.await?;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retry budget starts too early

Medium Severity

When construct_sweep_tx_to uses inner_retry with max_elapsed_time, that limit is measured from when the caller built the backoff, not from the sweep’s RPC steps. Work before the first with_retry (for example rpc_client().await in construct_sweep_to) and local scanning between steps still advance the same elapsed clock, so daemon retries can stop early even though the 45s budget was meant for those requests.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 950658c. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant