fix: resolve browser cookies login issue after trigger merged#1397
Merged
fix: resolve browser cookies login issue after trigger merged#1397
Conversation
On Windows, subprocess.Popen uses CreateProcess which cannot execute .cmd files directly. This causes FileNotFoundError when launching the Electron login browser via bare "npx" command in the packaged app. Fix by: - Resolving npx path via ~/.eigent/bin/npx.cmd or shutil.which fallback - Wrapping the command with cmd.exe /d /s /c on Windows - Ensuring ~/.eigent/bin is on PATH for the spawned process Closes #1376
bytecii
reviewed
Mar 3, 2026
…-ai/eigent into fix/windows-npx-createprocess-cmd
Collaborator
Author
|
@bytecii Fixed |
nitpicker55555
changed the title
4pmtong
approved these changes
Mar 3, 2026
Collaborator
4pmtong
left a comment
4pmtong
left a comment
There was a problem hiding this comment.
LGTM, Thanks @nitpicker55555
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subprocess.PopenusesCreateProcesswhich cannot execute.cmdfiles directly, causingFileNotFoundErrorwhen launching the Electron login browser via barenpxcommand in the packaged app~/.eigent/bin/npx.cmdorshutil.whichfallback, wrap withcmd.exe /d /s /con Windows, and ensure~/.eigent/binis on PATH for the spawned processCloses #1376
Test plan
🤖 Generated with Claude Code