fix(inputmask): prevent digit shift across section boundaries on delete#1
Open
ehsanshrz wants to merge 1 commit into
Open
fix(inputmask): prevent digit shift across section boundaries on delete#1ehsanshrz wants to merge 1 commit into
ehsanshrz wants to merge 1 commit into
Conversation
When using InputMask with a segmented pattern like '99.99.9999', pressing Backspace or Delete inside one section would shift digits from subsequent sections into the current one, causing values like '10.04.2026' to bleed across the '.' separators. Root cause: shiftL() iterated with seekNext() which skips over fixed mask characters (null entries in the tests array). This allowed the left-shift loop to pull digits across separator boundaries. Fix: Added a countFixedChars() helper that counts null (fixed) positions in a range. Before each shift step, we compare the number of fixed characters encountered on the destination side (begin..i) vs. the source side (end+1..j). If they differ, the shift has crossed a section boundary and we break early. The fix is applied to both the InputMask directive and the InputMask standalone component classes. Fixes primefaces#19629
ehsanshrz
force-pushed
the
fix/inputmask-shift-across-sections
branch
from
4660027 to
dfc1680
Compare
|
Thank you for your contribution! We will review your PR shortly. Please make sure to manually link it to an issue for proper tracking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes primefaces#19629