Repository navigation
chore(rust): eliminar los avisos de compilación por plataforma (#246) - #247
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue relacionada
Closes #246
Alcance
Acota con
#[cfg(...)]los símbolos que solo se usan en algunas plataformas, para quecargocompile sin avisos en el cratequorb. Sin#[allow(...)]generales y sin cambio de comportamiento.providers/claude.rs,providers/gemini.rs: se eliminause std::path::Path(sin uso en ninguna plataforma).KeychainOutcome::Session/TimedOuty sus ramas delmatchpasan acfg(target_os = "macos"), el único lugar donde se construyen.detail_placement.rs:rooted_origin,to_physicalySETTLEse importan solo en Linux, donde los usaUiSurface.cli_process.rs:let mut child→let child(run_pipelinedrecibe el hijo por valor).login.rs:path_withsolo en Windows;path_with_currenten Windows y tests;split_login_commanden Linux y tests.wm_compat.rs:with_display_backenden Linux y tests.wsl/process.rs:SCRIPT_READ_PIDsolo en tests (producción usaSCRIPT_READ_IDENTITY).uninstall.rs: el helper de borrado de datos de NSIS (Plan,purge,is_link,owned_target, variantes deFailuree imports) en Windows y tests. Estos 6 avisos aparecían en Linux.Validación
cargo check --all-targets --lockedsin avisos (antes: 13 en la lib y 5 en tests).cargo test --locked: 509 passed, 5 ignored, 0 failed.cargo fmt --checkenode scripts/i18n-inventory.mjs --check: OK.