Repository navigation
fix(web): a registry answer from before a role change, or an older failure, no longer moves the attributor - #769
Merged
Merged
Conversation
…ilure, no longer moves the attributor (#768) reset() bumps a generation; an answer asked for under an earlier one changes nothing and leaves its rows without a registry. A failure older than the current slice no longer sets failedAt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TDXX3ZV8LEdZgVTNFYFvZi
…next ask (#768) Guards the order of the generation check and the failure branch. Fails when the check is moved below it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TDXX3ZV8LEdZgVTNFYFvZi
Merged
efiten
pushed a commit
that referenced
this pull request
Oct 31, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>app: 1.32.1</summary> ## [1.32.1](app-v1.32.0...app-v1.32.1) (2026-10-31) ### Bug Fixes * **web:** a callout with its control in the menu sends the tour copy into the panel ([#760](#760)) ([8592da6](8592da6)) * **web:** keep the bar's labels on one line at tablet widths ([#759](#759)) ([f27390c](f27390c)) </details> <details><summary>server: 1.11.1</summary> ## [1.11.1](server-v1.11.0...server-v1.11.1) (2026-10-31) ### Performance Improvements * **server,web:** one point query per hex refresh for both cell sizes ([#755](#755)) ([78868fc](78868fc)) </details> <details><summary>web: 1.28.1</summary> ## [1.28.1](web-v1.28.0...web-v1.28.1) (2026-10-31) ### Bug Fixes * **web:** a callout with its control in the menu sends the tour copy into the panel ([#760](#760)) ([8592da6](8592da6)) * **web:** a registry answer from before a role change, or an older failure, no longer moves the attributor ([#769](#769)) ([087377d](087377d)) * **web:** date a registry slice from when it was asked for ([#765](#765)) ([77badec](77badec)) * **web:** keep the bar's labels on one line at tablet widths ([#759](#759)) ([f27390c](f27390c)) ### Performance Improvements * **server,web:** one point query per hex refresh for both cell sizes ([#755](#755)) ([78868fc](78868fc)) ### Code Refactoring * **web:** drop the name-redraw hold, MapLibre never closes a popup on redraw ([#770](#770)) ([ba9a9b0](ba9a9b0)) ### Tests * **web:** release the mocked resolver when the popup is open, not after 600 ms ([#762](#762)) ([2abc959](2abc959)) * **web:** retry the zoomfade hover until a painted cell answers ([#767](#767)) ([9331dfa](9331dfa)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #768
What changes
createRowAttributor(web/rowattribution.js):reset()(a change of role,web/map.js:610) bumps ageneration. An answer asked for under an earlier generation writes neither the slice norfailedAt, and its own rows read without a registry (rule: estimate). A member's answer that lands after a logout therefore names nothing for the guest.failedAtwhen no newer slice exists (!slice || slice.at <= askedAt), the rule fix(web): date a registry slice from when it was asked for #765 applies to a success.Tests
rowattribution.test.js:drops an answer that was asked for before a reset: the rows readestimateand the next call asks again;does not let an older failure that lands late hold back asks a newer answer allows: 3 asks, not 2;does not let a failure asked for before a reset hold back the first ask after it(added after review): fails when the generation check is moved below the failure branch.The first two fail without the change; the third guards the order of the two checks.
relaynames.spec.js+auth.spec.js26/26.targetpicker.spec.js:216. It also fails 1 of 8 runs with master'srowattribution.js, and passes 8 of 8 with this one, so it is not from this change.Not done
🤖 Generated with Claude Code
https://claude.ai/code/session_01TDXX3ZV8LEdZgVTNFYFvZi