Repository navigation
feat(rx-coverage): name the repeaters that picked up an uplink ping - #22
Merged
Merged
Conversation
The Uplink tooltip listed first hops as 2-byte prefixes. /api/uplink-coverage now adds first_hop_names, parallel to first_hops, resolved with one batchResolveHeardKeys call per response (nodes plus client_node_names). An unknown, ambiguous, blacklisted or hidden prefix gets an empty name and the tooltip keeps showing the prefix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Uplink layer tooltip showed "picked up by: C0CD, 1403". It now shows the repeater names.
cmd/server/uplink_coverage.go:nameUplinkFirstHopsaddsfirst_hop_names(parallel tofirst_hops) with onebatchResolveHeardKeyscall for all prefixes in the response. Same rules as the RX dashboard: nodes plusclient_node_names, an ambiguous, unknown, blacklisted or hidden prefix gets"".public/rx-coverage.js: the tooltip uses the name, falls back to the uppercase prefix.first_hopsis unchanged, so the response stays backward compatible.Tests
go test ./cmd/serverpasses;TestUplinkCoverageEndpointchecks a unique prefix gets its name and an ambiguous one stays empty.tests/unit/test-rx-coverage-uplink.jschecks the name replaces the prefix, is escaped, and an empty name keeps the prefix.scripts/check-xss-sinks.sh --file public/rx-coverage.jsexit 0.🤖 Generated with Claude Code