3DS: fallback to temp file for embedded music so data.win tracks play - #47
Open
frenzi4309 wants to merge 14 commits into
Open
3DS: fallback to temp file for embedded music so data.win tracks play#47frenzi4309 wants to merge 14 commits into
frenzi4309 wants to merge 14 commits into
Conversation
Some 3DS/SDL_mixer builds cannot load in-memory music via Mix_LoadMUS_RW. When Mix_LoadMUS_RW fails, write the embedded music bytes to a temporary file next to the archive and load with Mix_LoadMUS as a fallback. Track and clean up temp files on shutdown.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…OOM on large data.win
…installs devkitPro on an Ubuntu runner, builds the 3DS CIA using makerom and bannertool, and uploads the resulting butterscotch.cia artifact for download.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…issing\n\nImprove CI robustness when installing devkitPro on runners.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…kp-pacman unavailable\n\nTry downloading prebuilt binaries into tools-local/bin; if that fails, attempt to build makerom from source on the runner.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Add makerom v0.19.0 (3DSGuy/Project_CTR) for CIA generation - Add bannertool 1.2.3 (carstene1ns/3ds-bannertool) for banner/icon creation These enable the build-cia CI workflow to produce CIA packages on GitHub runners without requiring dkp-pacman or host package manager installation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Update workflow to properly set DEVKITPRO environment variable - Ensure tools-local/bin is in PATH during CIA build - Streamline tool setup to use prebuilt binaries already in repo - Install arm-none-eabi-gcc toolchain on CI runner Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Add cmake files from devkitPro to 3ds/cmake/ - Update CMakeLists.txt to use local toolchain as fallback when DEVKITPRO is not set - Enables CI to build 3DS targets without requiring full devkitPro installation Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Remove explicit DEVKITPRO environment setup - Rely on bundled cmake files and local toolchain - Install build tools (make, gcc-arm-none-eabi) directly on runner - Ensures build uses CMAKE_SOURCE_DIR-relative paths Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Fix relative include() statements to use CMAKE_CURRENT_LIST_DIR - Enables all cmake modules to be found when using local toolchain - dkp-asset-folder.cmake, dkp-embedded-binary.cmake, devkitARM.cmake - dkp-gba-ds-utils.cmake, dkp-linker-utils.cmake Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some 3DS builds fail to play embedded music from data.win: SDL_mixer's Mix_LoadMUS_RW does not reliably load in-memory music blobs on the 3DS toolchain, causing only SFX to play.
What I changed
Notes and trade-offs
Testing
If this looks good I can also produce a CI-friendly patch to avoid temp files on platforms where Mix_LoadMUS_RW works; otherwise this is a pragmatic fix for 3DS.