Skip to content

Fixed submodules exercise to work with newer git versions#389

Open
vivekveerappan wants to merge 2 commits into
eficode-academy:masterfrom
vivekveerappan:fix/submodules-for-newer-git-version
Open

Fixed submodules exercise to work with newer git versions#389
vivekveerappan wants to merge 2 commits into
eficode-academy:masterfrom
vivekveerappan:fix/submodules-for-newer-git-version

Conversation

@vivekveerappan

@vivekveerappan vivekveerappan commented Jun 14, 2026

Copy link
Copy Markdown

Fix Git submodule lesson

Summary

The command git submodule add ../remote include fails as newer git versions block file protocol by default
git -c protocol.file.allow=always is a temporary one-time override for just this command.

Summary by CodeRabbit

  • Documentation
    • Updated the submodule setup instructions to use a one-time Git command override that allows the file protocol on newer Git versions by default.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cee7b547-5f65-4ff2-906b-b76380a99028

📥 Commits

Reviewing files that changed from the base of the PR and between 4eb326e and 4dcacf9.

📒 Files selected for processing (1)
  • submodules/README.md
✅ Files skipped from review due to trivial changes (1)
  • submodules/README.md

Walkthrough

The submodules/README.md exercise instruction for adding a submodule is updated to prepend a -c protocol.file.allow=always Git config override to the git submodule add command, along with a note explaining that newer Git versions block the file protocol by default.

Changes

Submodule Exercise README Fix

Layer / File(s) Summary
Add protocol.file.allow=always override
submodules/README.md
The git submodule add command is replaced with git -c protocol.file.allow=always submodule add, and a note is added explaining that newer Git versions block the file protocol by default.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit once tried to add a submodule with glee,
But newer Git versions said, "No file protocol for free!"
So a tiny -c flag was tucked in just right,
protocol.file.allow=always — now the command works bright.
Hop hop, the exercise runs smooth once more! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a submodules exercise for compatibility with newer Git versions that block the file protocol by default.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@submodules/README.md`:
- Around line 22-23: The git command in the submodule addition instruction
contains a syntax error where `git-c` appears instead of `git -c` (note the
space instead of hyphen). Correct this typo by changing `git-c
protocol.file.allow=always` to `git -c protocol.file.allow=always` in the
README.md file so the command will execute properly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 03adc5b3-6afb-4c1c-8639-df1d4d758aec

📥 Commits

Reviewing files that changed from the base of the PR and between 7d2c18f and 4eb326e.

📒 Files selected for processing (1)
  • submodules/README.md

Comment thread submodules/README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant