Skip to content

fix: TS diagnostic in events middleware and TextField prop binding order #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enricopolanski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: TS diagnostic in events middleware and TextField prop binding order #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/src/lib/middleware/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ import { Events } from "#services/Events"
import { makeSSE } from "@effect-app/infra/middlewares"
import * as Effect from "effect-app/Effect"

// @effect-diagnostics effect/returnEffectInGen:off
export const makeEvents = Effect.gen(function*() {
const events = yield* Events

return makeSSE(ClientEvents)(events.stream)
})
2 changes: 1 addition & 1 deletion frontend/components/TextField.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<v-text-field
:type="field.type === 'float' || field.type === 'int' ? 'number' : 'text'"
v-bind="$props"
:type="field.type === 'float' || field.type === 'int' ? 'number' : 'text'"

@patroza patroza Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that the original is the correct one; the default should be set by us and optional props should override it when set. However the types of the props are wrong; they don’t show up as optional but always set to X | undefined, I reckon, hence the warning.

The better workaround short of fixing the actual issue in the original typings or vue-tsc or whichever is the culprit, is to manually merge the properties on the v bind level: { …$props, type: $props.type ?? field.type === …

@enricopolanski enricopolanski Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought $props was there only to allow passing vuetify's own props.

:model-value="convertIn(props.modelValue as any, field.type)"
:required="field.metadata.required"
:rules="props.extraRules ? [...props.extraRules, ...field.rules] : field.rules"
Expand Down