Repository navigation
CLI contract 1.0: no linger line when loginctl can't answer; reference headers name 1.0 - #23
Merged
Merged
Conversation
…e headers name 1.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From G3, the CLI-contract rollout's final sweep. It goes with cli-contract#9 (SPEC 1.0).
loginctlcan't answer,managers service installused to print "If you log out (this check could not reach loginctl), a user service…" and thesudoline. It now prints nothing, as Hallway, Local Review and BragDoc already did and as the reference'slingerAdvicenow does. The line still prints when linger is off.doctorstill reports the unknown case as skipped, andstatusalready warned only when it's off.lingerNoteis exported and unit-tested for off, unknown, on, and macOS.enable-linger, so its fakeloginctlnow saysLinger=no. A new test checks thatinstallsays nothing about linger whenloginctldoesn't answer.reference/file now says@ 1.0. Each was diffed against cli-contract's currentreference/first.runtime-file.tswas the one stale copy in the sweep: headed@ SPEC 0.1and reformatted to double quotes. It's now the verbatim reference file, the same as Paddock's, headed@ 1.0; local changes: none.reference/shows nothing the header doesn't explain (cli-contract#9'sreference/README.mdrule). The(with #7, d5ddc0e)note is dropped: 1.0 includes it.@managers/server.Checks: typecheck is clean, and
vitest run test/unit/cli-passes (346 tests). This box has no systemd, so the real-systemd job in CI is the live check.🤖 Generated with Claude Code