Skip to content

chore(deps): unblock the npm audit gate (zod, body-parser; triage nodejs-whisper and vite) - #19

Merged
edspencer merged 1 commit into
mainfrom
fix/npm-audit-nov
Nov 5, 2026
Merged

edspencer merged 1 commit into
mainfrom
fix/npm-audit-nov

Conversation

@edspencer

Copy link
Copy Markdown
Owner

npm audit (high/critical) is red on main itself, with no commit: four advisories published since the last green run (2026-10-18). It blocks every PR, including #18.

Advisory Package What
GHSA-mrhx-c7xc-m3w5 zod Fixed: zod ^4.6.6 (deduped to 4.6.7). Reachable in principle — every state write goes through a strict zod schema — so this one is a real fix, with a patch changeset.
GHSA-27r3-jxmh-p828 body-parser Fixed: 2.4.0 in the lockfile (@modelcontextprotocol/sdk → express 5).
GHSA-2f48-3555-fpx6 nodejs-whisper Exception. Command injection via a crafted audio file path in a shell ffmpeg call. The dependency is optional and used only with dictation local (default off); the only path it ever gets is server-built (mkdtemp dir + audio.wav, already transcoded to WAV). The fix is 0.4, a major that adds a native addon — a separate change.
GHSA-587h-7wmj-h5pm vite 5 Exception. Windows-only launch-editor bypass in the vite dev server; production serves the built bundle through Fastify. Fix needs vite 6.

The braces exception no longer matches anything and is removed (from the JSON and the doc table). docs/security/npm-audit.md has each row.

Also ports paddock#992: test/bin/claude's sleep() was a busy-wait that pegged a core for every hold, the cause of Paddock's long-standing E2E flake (edspencer/paddock#947). Managers' copy had the identical spin; now Atomics.wait.

Testing: npm run audit:check → "no undocumented high/critical advisories". Typecheck clean; server tests 2986 passed, 0 failed.

🤖 Generated with Claude Code

…ejs-whisper and vite)

`npm audit (high/critical)` went red on main with no commit, as four new
advisories published:

- zod GHSA-mrhx-c7xc-m3w5: fixed, zod ^4.6.6 (deduped to 4.6.7).
- body-parser GHSA-27r3-jxmh-p828: fixed, 2.4.0 in the lockfile (MCP SDK -> express 5).
- nodejs-whisper GHSA-2f48-3555-fpx6: exception. Optional, dictation `local`
  only, and the only path it is given is a server-built mkdtemp audio.wav.
  The fix is 0.4, a major that adds a native addon.
- vite GHSA-587h-7wmj-h5pm: exception. Dev server only, Windows only.

The braces exception no longer matches anything and is removed.

Also ports paddock#992: the fake claude's sleep() was a busy-wait that pegged
a core for the length of every hold, the cause of Paddock's long-standing
E2E flake (edspencer/paddock#947). Managers' copy had the same spin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@edspencer
edspencer merged commit 2b760a6 into main Nov 5, 2026
4 checks passed
@edspencer
edspencer deleted the fix/npm-audit-nov branch November 5, 2026 08:18
@github-actions github-actions Bot mentioned this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant