Android: Fixing issue where activity was being recreated for local no…#35
Closed
DottorPagliaccius wants to merge 2 commits into
Closed
Android: Fixing issue where activity was being recreated for local no…#35DottorPagliaccius wants to merge 2 commits into
DottorPagliaccius wants to merge 2 commits into
Conversation
…void starting with MainLauncher Activity added notification Id parameter to activity Extras
Author
|
I also add a way to specify custom Intent Action Filter; furthermore, I add notification id to Intent Extras (and some minor refactoring) |
Owner
|
Hi @DottorPagliaccius - we did some revamping to this repo and moved it to a dedicated repo (https://github.com/edsnider/LocalNotificationsPlugin) (see #37). Would it be possible for you to pull latest from the new repo and re-submit this PR on the new repo? |
Author
|
@edsnider Done ;) |
Owner
|
Thanks! |
Owner
|
PR opened in new repo: edsnider/localnotificationsplugin#4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jamesmontemagno
I use @gadzair's fix in both Show and OnReceive, without upgrading Support.V4 library as in #29.