Updated display of Maximum Summon by Yoshi80 · Pull Request #300 · edo9300/edopro

Yoshi80 · 2026-02-28T12:41:15Z

The list of features included in this PR is the following:

Maximum Summoned monsters on the field now display as a single monster.
Change the card hint when Maximum Summoning to display all 3 pieces at once.
Maximum Summoned monsters on the field now only show one Level and don't show their DEF.
Selecting a Maximum Summoned monster on the field can be done by selecting either of its pieces.
A monster whose only Special Summon procedure is a Maximum Summon will display "Maximum Summon".
When selecting zones to place monsters on the field, if only one zone is a valid choice, that zone will be chosen automatically.

… Summoning

edo9300 · 2026-03-08T00:41:18Z

+			if(mcenter) {
+				driver->setMaterial(matManager.mSelField);
+				int seq = mcenter->sequence;
+				if(seq > 0) {
+					Materials::QuadVertex side;
+					for(int i = 0; i < 4; ++i) side[i] = matManager.vFieldMzone[dField.hovered_controler][seq - 1][i];
+					side[0].Pos = side[0].Pos.getInterpolated(side[1].Pos, 0.5f);
+					side[2].Pos = side[2].Pos.getInterpolated(side[3].Pos, 0.5f);
+					driver->drawVertexPrimitiveList(side, 4, matManager.iRectangle, 2);
+				}
+				driver->drawVertexPrimitiveList(matManager.vFieldMzone[dField.hovered_controler][seq], 4, matManager.iRectangle, 2);
+				if(seq < 4) {
+					Materials::QuadVertex side;
+					for(int i = 0; i < 4; ++i) side[i] = matManager.vFieldMzone[dField.hovered_controler][seq + 1][i];
+					side[1].Pos = side[1].Pos.getInterpolated(side[0].Pos, 0.5f);
+					side[3].Pos = side[3].Pos.getInterpolated(side[2].Pos, 0.5f);
+					driver->drawVertexPrimitiveList(side, 4, matManager.iRectangle, 2);
+				}
+				return;


here all the drawing should be doable with a single vertex drawing (since you're drawing 3 rectangles that in the end are forming a single rect)

edo9300 · 2026-03-08T00:42:48Z

+				                               for(size_t i = 0; i < rects.size() - 1; ++i) {
+				                                       rects[i].LowerRightCorner.X = rects[i + 1].UpperLeftCorner.X;
+				                               }			} else {


the code is not properly indented

edo9300 · 2026-03-08T00:43:27Z

+			for(size_t i = 0; i < codes.size(); ++i) {
+				auto cardtxt = imageManager.GetTextureCard(codes[i], imgType::ART);
+				auto cardrect = irr::core::rect<irr::s32>(irr::core::vector2di(0, 0), irr::core::dimension2di(cardtxt->getOriginalSize()));
+				driver->draw2DImage(cardtxt, rects[i], cardrect, 0, matManager.c2d, true);
+			}


this is more of a note for myself that in case this could be made a single call to draw2DImageBatch

edo9300 · 2026-03-08T00:48:20Z

+		if(pcard->IsMaximumSide()) {
+			float offset = 0.4f;
+			if(controler == 0) {
+				if(sequence == 1) t->X += offset;
+				else if(sequence == 3) t->X -= offset;
+			} else {
+				if(sequence == 1) t->X -= offset;
+				else if(sequence == 3) t->X += offset;
+			}
+		}


currently IsMaximumSide doesn't enforce a maximum side piece to be sequence 1/3. In case either that has to be checked there, or this piece of code needs to be made sequence agnostic and check if the card is the left or right piece and act accordingly

I'm not really sure how to proceed here because even though the client doesn't enforce the sequence of the maximum side pieces, it is handled script-wise in the proc_maximum. And because of this, a monster in Maximum Mode will always have its side pieces in the same sequence.

edo9300 · 2026-03-08T00:53:09Z

+			ClientCard* mcenter = nullptr;
+			for(int p = 0; p < 2; ++p) {
+				for(auto pcard : dField.mzone[p]) {
+					if(pcard && pcard->code == showcardcode && pcard->IsMaximumCenter()) {


this isn't technically right, since both players could have the same card on the field, and for some reasons they might have different side pieces, leading to wrong popup image being displayed. But this is due to a limitation of how the client does things atm, so it's something to be addressed at a later time in case

I don't understand this part. In all my testing, the correct popup image has always been displayed correctly, even with different side pieces. Could you give me an example of this ?

player 0 has a maximum monster in play with a center piece x and 2 side pieces

player 1 summons a maximum with same center piece but another pair of side pieces

this logic would show player 0's maximum pieces

edo9300 · 2026-03-08T00:54:58Z

+#include <unordered_map>
 #include <IrrlichtDevice.h>
 #include <ISceneManager.h>
+#include <IFileSystem.h>
+#include <IReadFile.h>


leftover headers

edo9300 · 2026-03-08T00:58:33Z

-			else clicked_card = 0;
+				if(clicked_card && clicked_card->IsMaximumSide()) {
+					ClientCard* center = clicked_card->GetMaximumCenter();
+					if(center && center->is_selectable)


checking for is_selectable will prevent the side pieces to be used for general actions like attacking or using effects. Is it intentional? i don't remember atm if side pieces can have individual effects requiring that piece specifically to be selected to be activated

This is intentional. Side pieces are not considered monsters on the field so they cannot attack or use effects, or do anything at all. You have to think that when in Maximum Mode, it become essentially just the center piece, who gains the effects of the side pieces.

Then removing the is_selectable check should be the way to go, since it'll consider clicking a side piece as clicking the center piece under any circumstance (currently it won't let you declare an attack by clicking on the side piece for example)

edo9300 · 2026-03-08T01:05:06Z

+ClientCard* ClientCard::GetMaximumCenter() {
+	if(IsMaximumCenter())
+		return this;
+	if(!(type & TYPE_MAXIMUM) || location != LOCATION_MZONE || !(position & POS_FACEUP))
+		return nullptr;
+	const auto& zone = mainGame->dField.mzone[controler];
+	if(sequence > 0 && sequence - 1 < zone.size()) {
+		ClientCard* neighbor = zone[sequence - 1];
+		if(neighbor && neighbor->IsMaximumCenter())
+			return neighbor;
+	}
+	if(sequence + 1 < zone.size()) {
+		ClientCard* neighbor = zone[sequence + 1];
+		if(neighbor && neighbor->IsMaximumCenter())
+			return neighbor;
+	}
+	return nullptr;
+}
+bool ClientCard::IsMaximumCenter() const {
+	return (status & STATUS_MAXIMUM_CENTER) != 0;
+}
+bool ClientCard::IsMaximumSide() const {
+	if(!(type & TYPE_MAXIMUM) || location != LOCATION_MZONE || !(position & POS_FACEUP))
+		return false;
+	const auto& zone = mainGame->dField.mzone[controler];
+	if(sequence > 0 && sequence - 1 < zone.size()) {
+		ClientCard* neighbor = zone[sequence - 1];
+		if(neighbor && neighbor->IsMaximumCenter())
+			return true;
+	}
+	if(sequence + 1 < zone.size()) {
+		ClientCard* neighbor = zone[sequence + 1];
+		if(neighbor && neighbor->IsMaximumCenter())
+			return true;
+	}
+	return false;
+}


some extra sanity checks might be added to these functions, like checking that a center piece is a center only if it has 2 sides, and all the 3 pieces are in the main monster zones. In case any of these conditions fail, then none of them should be considered part of a maximum monster

…center status

…1 location

Yoshi80 added 14 commits February 28, 2026 12:03

updated text boxes to say Maximum Summon

770d507

used real Maximum Summon string

419bf04

Fixed Maximum Summon display when multiple procedure exist

09fca54

removed useless string check

8d67c1e

update Maximum Summoned stats display

5abb8a5

Keep constants up to date with core + fix Maximum display when Normal…

5362210

… Summoning

updated Maximum Summon display location

1210110

fixed crash when trying to access Extra Deck

824bd1e

auto-place cards when only 1 option is available

39fc3a9

updated highlight and selection of Maximum Mode monsters

9acc65c

updated selecting hint on Maximum Mode monsters

3bc839a

updated Maximum pieces display

434c257

final changes

9d27eeb

updated duel client to not read card scripts

a2b65e7

Yoshi80 force-pushed the maximum-display branch from 8c6ff87 to a2b65e7 Compare February 28, 2026 18:05

Make auto-card placement if only one zone is available into a setting

67513ae

edo9300 reviewed Mar 8, 2026

View reviewed changes

Yoshi80 and others added 12 commits March 8, 2026 16:00

small fixes + fix maximum summon popup + handle clicked side pieces

05dd151

update Maximum card resize to fit all screen ratios

9822c04

simplify maximum spsummon popup logic

b7c8442

simplify some maximum side checks

7e3f129

remove leftover redoundant check in card hint display

f42c145

simplify maximum highlighting drawing logic

b742283

simplify maximum hint string printing

ba73eba

sync core constants

c9c8d0f

revert no longer used ShowCardInfo isMaximumSummoned flag

3255111

treat as maximum side any card that has a neighbour with the maximum …

d1afd92

…center status

don't default enable the option for automatic zone selection if only …

ace8795

…1 location

fixed typo

8010a53

edo9300 force-pushed the master branch from b6536ab to 6d2965d Compare May 5, 2026 19:35

edo9300 force-pushed the master branch from 5036181 to b52ce46 Compare June 19, 2026 15:10

Conversation

Yoshi80 commented Feb 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants