Repository navigation
Shared build - #116
Merged
Merged
Shared build#116
Conversation
bleggett
force-pushed
the
bleggett/test-shared-build
branch
4 times, most recently
from
August 26, 2025 21:35
bb62074 to
8393257
Compare
bleggett
force-pushed
the
bleggett/test-shared-build
branch
2 times, most recently
from
August 26, 2025 21:37
117045c to
5975ddb
Compare
kaniini
previously approved these changes
Aug 26, 2025
bleggett
dismissed
kaniini’s stale review
August 26, 2025 21:55
The merge-base changed after approval.
bleggett
force-pushed
the
bleggett/test-shared-build
branch
from
August 26, 2025 21:55
5975ddb to
a3c1890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we duplicated (sorta) logic between the CI action and the "build" action.
One of the side effects of this was we ignored the defined
config.yamlrunner size for a particular matrix combo for CI.This moves the "matrix" bit into a shared workflow, which can either be invoked by
test.yamlorbuild.yaml.The permissions (including publish permissions) of the shared workflow entirely come from the declared permissions parent invoking workflow, so this doesn't alter the security model, and should build exactly the same variants as the old standalone
testjob did.This depends on/should go in after: #113