Make SageMaker image URI region-agnostic#31
Open
baloglu321 wants to merge 2 commits intoed-donner:mainfrom
Open
Make SageMaker image URI region-agnostic#31baloglu321 wants to merge 2 commits intoed-donner:mainfrom
baloglu321 wants to merge 2 commits intoed-donner:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the cross-region deployment issue where SageMaker model creation fails if the provider region is not us-east-1.
Changes:
Modified main.tf in the aws_sagemaker_model resource.
Replaced the static region part of the ECR URI with ${var.aws_region}.
Why this is better: Users can now deploy this project in any AWS region (e.g., eu-central-1, us-west-2) without having to manually find and update the Deep Learning Container URI for their specific region. It makes the infrastructure-as-code more robust and portable.
Verified the fix by deploying in eu-central-1 and successfully invoking the endpoint to receive embeddings.
Fixes #30