Fix scanner memory typing in deal pipeline#2
Open
sasmita016 wants to merge 3 commits intoed-donner:mainfrom
Open
Fix scanner memory typing in deal pipeline#2sasmita016 wants to merge 3 commits intoed-donner:mainfrom
sasmita016 wants to merge 3 commits intoed-donner:mainfrom
Conversation
Title Fix scanner memory typing in deal pipeline What this PR does Aligns the scanner, planner, and autonomous planner to use List[Opportunity] consistently for memory. Updates related docstrings to reflect the correct memory type. Why this change is needed The scanner previously typed memory as List[str] (URLs) but used it as List[Opportunity] (opp.deal.url), which could break at runtime and confused the pipeline contract. This change ensures the scanner pipeline matches actual usage and avoids type-driven runtime errors. Notes This is a behavior‑preserving change focused on type consistency; no workflow logic changes. Verified with a targeted smoke test of ScannerAgent.test_scan() and fetch_deals() using Opportunity objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Notes
No logic changes; only type alignment and doc updates.\n- Smoke-checked by exercising ScannerAgent.test_scan() and fetch_deals() with Opportunity memory.