Move mat and trunc_series into num/, add num/linear_fn - #89
Merged
Conversation
Co-Authored-By: Andrew He <7088371+ecnerwala@users.noreply.github.com>
Co-Authored-By: Andrew He <7088371+ecnerwala@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
GCC Code Coverage Report📂 Overall coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mat<num, N>andtrunc_series<num, N>move verbatim out offft/engines/algebras.hppintonum/mat.hppandnum/trunc_series.hpp(now innamespace walainstead ofwala::fft::engines); the componentwise wrapper engines are unchanged and pick them up by include.New
num/linear_fn.hpp:with
operator(),*,*=,==, plus a small Catch2 test.The three
verify/ds/affine segtree solutions drop their locallinear_fnstructs and usewala::linear_fn<num>(f * lazyfor composition, default construction for identity, andpoint_set_range_compositefolds the query directly viax = seg[a](x)). All three re-verified AC locally; unit tests pass.Link to Devin session: https://app.devin.ai/sessions/a0c142d72b3848a8926b2fc111685565
Requested by: @ecnerwala