[python] update the python build#50
Merged
Merged
Conversation
tmi
force-pushed
the
feature/pythonUpdate
branch
3 times, most recently
from
201ee28 to
197a0f2
Compare
pmaciel
approved these changes
Jun 10, 2026
tmi
force-pushed
the
feature/pythonUpdate
branch
2 times, most recently
from
0cd7290 to
3e9cd16
Compare
Contributor
Author
pmaciel
force-pushed
the
feature/pythonUpdate
branch
from
3e9cd16 to
bb0146f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the ecmwf/eckit#297, with a few notable differences
1/ changes the mir python package structure to:
1a/ we install the .so as mir/_mir.cython.so, not as _mir.cython.so
1b/ we change the mir init import from _mir to mir._mir
this is motivated by: a/ resemble eckit structure b/ wheels ideally don't install outside of their top level package dirs c/ I was not able to bundle it into the wheel otherwise
2/ we exclude the whole
_mir*instead of just_mirat wheel building time, as nested packages need to be fully matched -- mir is more rich than eckit in this fashion3/ we force virtual env picking at cmake config time, as it was failing otherwise
4/ we install numpy at precompile time to make sure it is found for the cythonization
5/ we fix the package requirements of mir to also include eckit
6/ we simplify the mir init to use findlibs.load