Skip to content

fix: Add 'mir-python' to mod_name check in version import #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HCookie wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: Add 'mir-python' to mod_name check in version import #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dab615a
Add 'mir-python' to mod_name check in version import
HCookie Apr 30, 2026
2ae3613
Merge branch 'develop' into fix/add-mir-python-to-modcheck
HCookie May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/cascade/executor/runner/packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@ def _parse_pip_install(pip_output: str) -> dict[str, Version]:


def _maybe_imported_version(mod_name: str) -> Version | None:
if mod_name in ("eccodes", "gribapi"):
# TODO presumably cacheable, unless None
if mod_name in ("eccodes", "gribapi", "mir-python"):
# the eccodes/gribapi __version__ is wrong, reporting that of eccodeslib
# => we must go to the importlib. This *invalidates* the post install
# check -- TODO after eccodes wheel fixed, remove this
Expand Down
Loading