Support str step range in xarray engine#721
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #721 +/- ##
===========================================
+ Coverage 90.66% 90.77% +0.10%
===========================================
Files 168 169 +1
Lines 12683 12916 +233
Branches 614 615 +1
===========================================
+ Hits 11499 11724 +225
- Misses 1001 1003 +2
- Partials 183 189 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #713
This PR adds the following changes:
Breaking changes
Separated the dimension names from the metadata keys used to generate the dimensions. Dimensions associated with the dimension roles are now taking the name of the
dimension role, irrespective of the metadata key the dimension role is mapped to. E.g.: the "level_type" dimension role now generates a dimension called "level_type". Previously, the dimension name was the name of the associated metadata key: e.g. it was "levtype" in the default profile. The old behaviour can still be invoked by using the newly addeddim_name_from_role_name=Falseoption.The
stepdimension role is now mapped to the"step_timedelta"metadata key, which is thedatetime.timedeltarepresentation of the"endStep"GRIB/metadata key. Previously, this role was mapped to the"step"key. Please note that due to this change whendim_name_from_role_name=Falseis used the step dimension will be called "step_timedelta" instead of "step".Deprecation
dimension rolechanged to "number" from "ens" in thedim_rolesoption ofto_xarray(). The old name is still available for backward compatibility but will be removed in a future release.Other changes
extra_dimsandfixed_dimsoptions to define both the name of the dimensions and the metadata keys to generate their values. Previously, these options only took a single/multiple metadata keys. E.g. both the options below will generate the "expver", "mars_stream" and "mars_class" dimensions using the "expver", "stream" and "class" metadata keys.New Xarray engine notebooks