Skip to content

Feature/sync kwarg on set#1011

Merged
sandorkertesz merged 2 commits into
developfrom
feature/sync-kwarg-on-set
Jun 8, 2026
Merged

Feature/sync kwarg on set#1011
sandorkertesz merged 2 commits into
developfrom
feature/sync-kwarg-on-set

Conversation

@sandorkertesz

@sandorkertesz sandorkertesz commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR adds the sync kwarg to the Field.set() method.

sync: bool
  When True, try to ensure the raw metadata is in sync with the modified field's components.
  It might not be possible and can raise an exception. Same as calling :meth:`sync` on the
  new field returned by :meth:`set`.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.38%. Comparing base (efc21b4) to head (9bcebfe).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1011      +/-   ##
===========================================
+ Coverage    81.35%   81.38%   +0.03%     
===========================================
  Files          236      236              
  Lines        15614    15636      +22     
  Branches       755      756       +1     
===========================================
+ Hits         12702    12725      +23     
  Misses        2686     2686              
+ Partials       226      225       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandorkertesz sandorkertesz merged commit d81303d into develop Jun 8, 2026
148 checks passed
@sandorkertesz sandorkertesz deleted the feature/sync-kwarg-on-set branch June 8, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants