Skip to content

Clean up within xr_engine profiles and docs#1006

Merged
sandorkertesz merged 1 commit into
developfrom
fix/xr-engine-profiles-and-docs-cleaning
Jun 1, 2026
Merged

Clean up within xr_engine profiles and docs#1006
sandorkertesz merged 1 commit into
developfrom
fix/xr-engine-profiles-and-docs-cleaning

Conversation

@pawel-wolff

Copy link
Copy Markdown
Contributor

Description

This PR fixes the following issues:

  • Docstring on to_xarray() and open_dataset() concerning attrs corrected and expanded
  • The profile-defined xr_engine keyword attrs uses format-agnostic metadata instead of GRIB keys. A related test was improved.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

…o format-agnostic

A related test improved

Documentation on xr_engine `*_attrs` corrected and expanded
@pawel-wolff pawel-wolff requested a review from sandorkertesz May 28, 2026 14:18
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.56%. Comparing base (e015000) to head (c815a37).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1006   +/-   ##
========================================
  Coverage    81.56%   81.56%           
========================================
  Files          236      236           
  Lines        15510    15510           
  Branches       756      755    -1     
========================================
+ Hits         12650    12651    +1     
  Misses        2634     2634           
+ Partials       226      225    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandorkertesz sandorkertesz merged commit a8d48bc into develop Jun 1, 2026
148 of 149 checks passed
@pawel-wolff pawel-wolff deleted the fix/xr-engine-profiles-and-docs-cleaning branch June 1, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants