Add ArrayView and LocalView method extent(Int) as in mdspan#390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new convenience method,
extent, to both theLocalViewandArrayViewclasses. Theextentmethod is a simple alias for the existingshapemethod, providing a more intuitive way to query the size of a specific array dimension.API enhancements for array views:
extent(Int idx)method toLocalView, which returns the number of values in the specified dimension and is equivalent to callingshape(idx)(src/atlas/array/LocalView.h).extent(Int idx)method toArrayView, also as an alias forshape(idx), improving consistency and usability (src/atlas/array/native/NativeArrayView.h).💣💥☠️ Static Analyzer Report ☠️💥💣
https://sites.ecmwf.int/docs/atlas/static-analyzer/PR-390