Add Fortran API for FunctionSpace checksum with array support#389
Merged
wdeconinck merged 3 commits intoJun 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the Fortran API for function space checksums, with a focus on deprecating old methods, expanding array API support, and improving deprecation handling. The changes also include new tests and internal refactoring to support these updates.
Key changes:
Deprecation Handling and Warnings
atlas_Deprecation_module.F90that provides environment-variable-controlled deprecation warnings and errors, allowing users to enable or disable deprecation messages for legacy API usage. [1] [2]get_checksummethods inCellColumns,EdgeColumns, andNodeColumnsmodules to emit warnings or errors (with clear migration guidance) when used, utilizing the new deprecation module and providing one-time warning subroutines. [1] [2] [3]Array API Expansion and Refactoring
atlas_FunctionSpace_module.F90to a Fypp template (atlas_FunctionSpace_module.fypp), and added a family ofchecksum_<dtype>_r<rank>functions, enabling direct checksum computation on arrays of various types and ranks. The genericchecksuminterface is now expanded to include these. [1] [2] [3] [4] [5]Testing Improvements
test_blockstructuredcolumns_checksum_array_api) to verify the new array API for checksums, ensuring correct results for various array slices and dimensions.These changes modernize the Fortran API, encourage migration to new interfaces, and provide robust mechanisms for managing deprecated functionality.
💣💥☠️ Static Analyzer Report ☠️💥💣
https://sites.ecmwf.int/docs/atlas/static-analyzer/PR-389