Add conservative limiters for the 'cons2' interpolation (field data colocation on nodes and cells supported!)#366
Open
sbrdar wants to merge 92 commits into
Open
Conversation
…der cons. remapping
…n every run in the metadata -max_memory_in_bytes_per_task-
…ervation_error to fix the cons. interpolation unit test
…nstead of the target field
…hange the intersection parameters of the source: src_iparam
… XStep source data
…eighbours in the .h-file
…n case of NodeColumns
…rce points (= either cell or node) in order not to act multiple times on the same target points
…to which target CSP, and not which node to which target CSP. Now the zeroslope is identical to cons-1 when every point is limited.
…the number of source is insufficient, i.e. smaller than ATLAS_INTERPOLATION_DETECTOR or limiter_detector_
…ize-. The larger the detector size the less likely limiting is. The limiter output can be -target- (default: the limited field), -points- (which target points will be limited), -contribution- (only the field value contribution from the limiter)
…Kaas, and U. S. Korsholm (2012)
…eparing for halo exchange and a parallel ILMC limiter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses the issue #347 to a add mass-conserving limiter for over-/under-shoots after the 2nd order conservative interpolation 'cons2'.
Add analytical functions XStep and SlottedCylinder to test limiters. In addition, a non-conservative 'clip' limiter is added for comparison.
The selection of limiter is done by passing one of the options to
ConservativeSphericalPolygonInterpolation:none,clip,zeroslope,ilmc.Gradient computation based on (Tomita et al., 2001) is singled out as subroutines
src_gradient_celldataandsrc_gradient_nodedata.Some bugs are fixed in the matrix-free version of conservative interpolation. The existing unit test for cons. interpolation is updated to include tests for matrix-free and matrix conservative interpolations.
The conservative interpolation statistics is updated to include limiter mass change. These statistics are computed if, i.e.
statistics.allis passed as an option to thecons2interpolator.Note that this PR replaces the previous PR #350 to extend it to all {
CellColumns,NodeColumns} -> {CellColumns,NodeColumns} combinations. In addition, note that this PR replaces also #365 to include an implementation of the ilmc limiter (cf. "A mass-conserving and multi-tracer efficient transport scheme inthe online integrated Enviro-HIRLAM model" by B. Sørensen, E. Kaas, and U. S. Korsholm).The previous PRs will be discarded.
The tool
sandbox/atlas-conservative-interpolationis completed with the following optionswhich can soon into
app/atlas-interpolation.The current limitation is that this implementation, albeit MPI-parallel, assumes that spherical polygons are indexed as source cells (not true when masked cells are present).
Contributor Declaration
By opening this pull request, I affirm the following: