fix(ci): gate Dependabot auto-merge on CI passing - #19
Open
pnehrer wants to merge 2 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing workflow uses
on: pull_requestandgh pr merge --auto --squash.Without branch protection rules,
--automerges immediately rather thanwaiting for CI to pass — Dependabot PRs were being squash-merged the moment
the workflow ran, before
Rust CIhad a chance to complete (or even start).Fix
Switch the trigger to
on: workflow_runtargetingRust CI. The job runsonly when the CI workflow completes successfully and the triggering event
was a
pull_requestfromdependabot[bot]. The merge step is still gated bythe existing patch/minor semver check (no major bumps).
Key differences from the old approach:
pull_requestworkflow_run(afterRust CIcompletes)conclusion == 'success'requiredgithub.actor == 'dependabot[bot]'inif:workflow_run.actor.login == 'dependabot[bot]'github.event.pull_request)head_shavia API