[GEF] Harmonize getCommand(Request) in EditPart with upstream class#1412
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Mar 27, 2026
Merged
Conversation
ptziegler
force-pushed
the
gef-edit-part-command
branch
3 times, most recently
from
ceeb431 to
86202d4
Compare
ptziegler
force-pushed
the
gef-edit-part-command
branch
from
86202d4 to
2b1ffd9
Compare
When calling this method, our EditPart first filters all edit-policies for those that are able to handle this request. This is not how it should be done in GEF; Instead, the check for whether a request is supported has to be done by edit-policy itself.
ptziegler
force-pushed
the
gef-edit-part-command
branch
from
2b1ffd9 to
895aa7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling this method, our EditPart first filters all edit-policies for those that are able to handle this request. This is not how it should be done in GEF; Instead, the check for whether a request is supported has to be done by edit-policy itself.