[GEF] Request should use relative mouse coordinates#1405
Open
ptziegler wants to merge 2 commits intoeclipse-windowbuilder:masterfrom
Open
[GEF] Request should use relative mouse coordinates#1405ptziegler wants to merge 2 commits intoeclipse-windowbuilder:masterfrom
ptziegler wants to merge 2 commits intoeclipse-windowbuilder:masterfrom
Conversation
Test Results 2 720 files ±0 2 720 suites ±0 10h 39m 0s ⏱️ - 24m 42s For more details on these failures, see this check. Results for commit 84f4886. ± Comparison against base commit 80df795. ♻️ This comment has been updated with latest results. |
This adapts the `getLocation()` method of the `DropRequest` classes to return the relative mouse coordinates, rather than the absolute coordinates. These coordinates are translated, where necessary, by the new `PolicyUtils.getAbsoluteLocation(...)` method. The GEF API expects relative coordinates for requests. So this step is necessary if we want to mix GEF classes with our classes. In addition to this, the `getRelativeLocation()` methods have now become obsolete and have been removed.
ptziegler
force-pushed
the
create-request
branch
from
2716d82 to
2f85d41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adapts the
getLocation()method of theDropRequestclasses to return the relative mouse coordinates, rather than the absolute coordinates. These coordinates are translated, where necessary, by the newPolicyUtils.getAbsoluteLocation(...)method.The GEF API expects relative coordinates for requests. So this step is necessary if we want to mix GEF classes with our classes. In addition to this, the
getRelativeLocation()methods have now become obsolete and have been removed.