USubscription v4 API re-write#326
Open
AnotherDaniel wants to merge 11 commits into
Open
Conversation
AnotherDaniel
added
enhancement
sophokles73
reviewed
Jun 17, 2026
sophokles73
left a comment
sophokles73
left a comment
Contributor
There was a problem hiding this comment.
There are a few things that I do not understand. In particular around the subscription change notifications. FMPOV we will need to be super clear about what these are good/used for before we make them mandatory ...
| When a client calls the `Subscribe()` function for a remote topic with xref:subscription-status[SubscriptionStatus] `UNSUBSCRIBE_PENDING`, uSubscription service *MUST* initiate the regular remote subscription process, i.e. send a subscription request to the remote uSubscription service and set xref:subscription-status[SubscriptionStatus] to `SUBSCRIBE_PENDING`. | ||
|
|
||
| [.specitem,oft-sid="req~usubscription-subscribe-notifications~1",oft-needs="impl,utest",oft-tags="USubscription"] | ||
| After a client calls the `Subscribe()` function, uSubscription service *MUST* send subscription change Notifications to that client whenever there are any changes to the state of the subscribed topic. |
Contributor
There was a problem hiding this comment.
What events will cause such a notification being sent to the client? What information will be conveyed to the client?
Is this about getting notified when the publisher does no longer publish to the topic?
Co-authored-by: Kai Hudalla <sophokles.kh@gmail.com>
sophokles73
reviewed
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-write of the uSubscription service specification, with associated API definitions using asyncapi, referencing protobuf message definitions.
This breaks the existing protobuf api - simplification, type changes, name changes, parameter ordering, etc.
Re-write initiated by some vague areas in the previous spec, as well as #320 and #321
Note: I still have to wrangle with oft, to verify requirement markers. WIP...