Migration to npm#534
Open
gfontorbe wants to merge 2 commits into
Open
Conversation
spoenemann
reviewed
Jun 10, 2026
| with: | ||
| node-version: '24' | ||
| - name: Update npm | ||
| run: npm install -g npm@latest |
Contributor
There was a problem hiding this comment.
Is this necessary? If yes, shall we pin the version number?
| "private": true, | ||
| "scripts": { | ||
| "prepare": "yarn run clean && yarn run build", | ||
| "prepare": "npm run clean && npm run build", |
Contributor
There was a problem hiding this comment.
Suggestion: remove the prepare script. In other projects, install really only installs dependencies. Building should be a separate step.
|
|
||
| // Use 'postCreateCommand' to run commands after the container is created. | ||
| "postCreateCommand": "yarn install" | ||
| "postCreateCommand": "npm install" |
Contributor
There was a problem hiding this comment.
After removing the prepare script, this should become npm install && npm run build
| "scripts": { | ||
| "prepare": "yarn run clean && yarn run build", | ||
| "prepare": "npm run clean && npm run build", | ||
| "clean": "lerna run clean", |
Contributor
There was a problem hiding this comment.
This can be replaced with npm run clean --workspaces. I think lerna is only used for publishing – we can kick it out later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes yarn in favor of npm and adapts scripts and configs where appropriate