Skip to content

Update IDResolver for multiple reference types Object#1710

Merged
mariusheine merged 2 commits intomainfrom
fix-wrong-id-resolver
Jul 17, 2025
Merged

Update IDResolver for multiple reference types Object#1710
mariusheine merged 2 commits intomainfrom
fix-wrong-id-resolver

Conversation

@TruongQuangSB
Copy link
Copy Markdown
Contributor

  • Require Model-PR#43
  • Fix wrong ID Resolver by multiple reference types Object

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2025

Test Results

121 tests  ±0   121 ✅ ±0   13s ⏱️ -5s
 28 suites ±0     0 💤 ±0 
 28 files   ±0     0 ❌ ±0 

Results for commit 6df20fd. ± Comparison against base commit fa6b16c.

This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both.
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@2f98635e
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@73fc518f
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@61f39bb
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@249e0271
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@4893b344
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@60ae7cf2, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@225e09f0, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@1c90029b, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@16e907b6, second=xxx], expected=multi/456/123/other=xxx]
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@3b95d13c
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@6b2e0f78
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@b174a73
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@2e3f79a2
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@1460c81d
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@4d2f9e3c, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@686b1e2d, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@ac4e690, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@29c244e, second=xxx], expected=multi/456/123/other=xxx]

♻️ This comment has been updated with latest results.

@mariusheine
Copy link
Copy Markdown
Contributor

/rebase

@github-actions
Copy link
Copy Markdown

License summary

❌ Not yet vetted dependencies:

Dependency License Status Ticket
p2/orbit/p2.eclipse.plugin/maven.net.sf.offo.artifact.fop-hyph/2.6.0 unknown restricted none
p2/orbit/p2.eclipse.plugin/maven.org.apache.poi.artifact.poi-ooxml-lite/5.0.0 unknown restricted none
p2/orbit/p2.eclipse.plugin/org.junit_3.8.2.v200706111738.nl_de/4.26.0.v20230220105658 unknown restricted none
  • Committers can request a license review via by commenting /request-license-review.
  • After all reviews have concluded, Committers can re-run the license-vetting check by commenting /license-check

Workflow run (with attached summary files):
https://github.com/eclipse-set/set/actions/runs/16343798386

@mariusheine mariusheine merged commit 05393db into main Jul 17, 2025
23 of 24 checks passed
@mariusheine mariusheine deleted the fix-wrong-id-resolver branch July 17, 2025 13:43
TruongQuangSB added a commit to SuB-PlanPro/set that referenced this pull request Jul 17, 2025
Co-authored-by: Marius Heine <m.heine@geprog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants