Skip to content

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Jan 5, 2026

  • Remove unused dependencies (non-exhaustive).
  • Remove unused third_party files.

Resolves #19

@arkjedrz arkjedrz requested a review from PiotrKorkus January 5, 2026 11:28
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

The created documentation from the pull request is available at: docu-html

@arkjedrz arkjedrz self-assigned this Jan 5, 2026
@arkjedrz arkjedrz force-pushed the arkjedrz_deps-scrub branch from d4043d4 to 4944ae7 Compare January 6, 2026 07:58
@arkjedrz arkjedrz temporarily deployed to workflow-approval January 6, 2026 07:58 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 5f1447c5-b1eb-4bb0-bbcf-6b3a4f6485dc
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.8 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.10.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 17.155s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@arkjedrz arkjedrz force-pushed the arkjedrz_deps-scrub branch from 4944ae7 to c3386cd Compare January 6, 2026 08:01
@arkjedrz arkjedrz temporarily deployed to workflow-approval January 6, 2026 08:01 — with GitHub Actions Inactive
@arkjedrz arkjedrz marked this pull request as ready for review January 6, 2026 08:01
@pawelrutkaq pawelrutkaq requested a review from rmaddikery January 6, 2026 08:05
@pawelrutkaq
Copy link
Contributor

@rmaddikery, @hoppe-and-dreams please review

# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************

load("@rules_cc//cc:cc_library.bzl", "cc_library")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit and changes do not reflect intent. Also please clarify why this change is made/required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll split those changes tomorrow. Reason for changes:
obraz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forked PR: #24

Copy link
Contributor

@rmaddikery rmaddikery Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Bazel 8+ managed via https://bazel.build/install/bazelisk

Then try the following:

$ bazel build //score/datarouter:datarouter

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmaddikery Please take a look into official C++ bazel example - https://github.com/bazelbuild/examples/blob/main/cpp-tutorial/stage1/main/BUILD

First versions of bazel did not require load statement for cc_binary / library but since 2019, there is a hint to use it as it will be a future incompatibility already.

@arkjedrz arkjedrz force-pushed the arkjedrz_deps-scrub branch from c3386cd to 450e1de Compare January 7, 2026 16:44
@arkjedrz arkjedrz temporarily deployed to workflow-approval January 7, 2026 16:44 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_deps-scrub branch from 450e1de to 8e19335 Compare January 7, 2026 16:45
@arkjedrz arkjedrz temporarily deployed to workflow-approval January 7, 2026 16:45 — with GitHub Actions Inactive
@arkjedrz arkjedrz changed the title infra: remove unused dependencies bazel: remove unused dependencies Jan 7, 2026
@arkjedrz arkjedrz requested a review from rmaddikery January 8, 2026 09:23
# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************

load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in 8e19335 is fine. If you exclude the other commit, we can merge the PR.

Reasoning: #24 (comment)

@arkjedrz arkjedrz requested a review from rmaddikery January 8, 2026 13:08
- Remove unused dependencies (non-exhaustive).
- Remove unused `third_party` files.
@arkjedrz arkjedrz force-pushed the arkjedrz_deps-scrub branch from 8e19335 to 823d938 Compare January 8, 2026 13:14
@arkjedrz arkjedrz deployed to workflow-approval January 8, 2026 13:14 — with GitHub Actions Active
Copy link
Contributor

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: remove unused dependencies

4 participants