-
Notifications
You must be signed in to change notification settings - Fork 6
infra: add CI workflows #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: add CI workflows #15
Conversation
|
The created documentation from the pull request is available at: docu-html |
MODULE.bazel
Outdated
| llvm.toolchain( | ||
| cxx_standard = {"": "c++17"}, | ||
| llvm_version = "19.1.0", | ||
| register_toolchains( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not register toolchain, use bazelrc.
5c26e3f to
5f7c0c2
Compare
f88cdbe to
326a14e
Compare
.github/workflows/tests.yml
Outdated
| - name: Run Tests via Bazel | ||
| run: | | ||
| echo "Running: bazel test //src/..." | ||
| bazel test //src/... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont we have tests in //score ?
326a14e to
ed4de84
Compare
PiotrKorkus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also bazel build //... doesnt work locally as well
.github/workflows/build.yml
Outdated
| jobs: | ||
| build: | ||
| name: Build Bazel Code | ||
| runs-on: ${{ vars.REPO_RUNNER_LABELS && fromJSON(vars.REPO_RUNNER_LABELS) || 'ubuntu-latest' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont have self-hosted runners in score, can be just ubuntu-latest
.github/workflows/build.yml
Outdated
| - name: Install protoc 26.1 | ||
| uses: arduino/setup-protoc@v3 | ||
| with: | ||
| version: 26.1 | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
step not needed, it works without it
.github/workflows/build_qnx8.yml
Outdated
| contents: read | ||
| pull-requests: read | ||
| with: | ||
| bazel-target: "//src/..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about //score/...?
| with: | ||
| # the bazel-target depends on your repo specific docs_targets configuration (e.g. "suffix") | ||
| bazel-target: "//:docs -- --github_user=${{ github.repository_owner }} --github_repo=${{ github.event.repository.name }}" | ||
| retention-days: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have 3 days here but docs-cleanup.yml runs daily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double checked, those are 2 different things being cleaned. Not valid anymore
.github/workflows/gitlint.yml
Outdated
| jobs: | ||
| lint-commits: | ||
| name: check-commit-messages | ||
| runs-on: ${{ vars.REPO_RUNNER_LABELS && fromJSON(vars.REPO_RUNNER_LABELS) || 'ubuntu-latest' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self-hosted part not needed
.github/workflows/tests.yml
Outdated
| run: | | ||
| # TODO: restore `//src/...` tests once provided. | ||
| # echo "Running: bazel test //src/..." | ||
| # bazel test //src/... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for the future it can be merged to single bazel test command - bazel test //src/... //score/...
* Log backend for rust frontend This is logger impl that bridges rust log frontend with C++ mw_log implementation Signed-off-by: Pawel Rutka <pawel.rutka.ext@qorix.ai> * Adress review findings * Adapt to cpp/rust structure as in persistency * Align to baselibs --------- Signed-off-by: Pawel Rutka <pawel.rutka.ext@qorix.ai>
- Add CI workflows. - Align Bazel config and deps. - Fix build-preventing and other minor issues.
ed4de84 to
fcd11d0
Compare
| git_override( | ||
| module_name = "score_toolchains_rust", | ||
| commit = "bcf8e5364f72cf136ec81960350a82e2b5c45449", | ||
| remote = "https://github.com/eclipse-score/toolchains_rust.git", | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be avaliable in v 0.2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't do due to eclipse-score/toolchains_rust#10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rust toolchain is going to change drastically soon. lets leave it as it is for week or two
MODULE.bazel
Outdated
| bazel_dep(name = "score_toolchains_gcc", version = "0.4", dev_dependency = True) | ||
| # S-CORE process rules | ||
| bazel_dep(name = "score_bazel_platforms", version = "0.0.3") | ||
| bazel_dep(name = "score_docs_as_code", version = "2.0.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump to 2.2.0
Fixes after review.
b307dfc to
1e6349c
Compare
pawelrutkaq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.