Skip to content

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Dec 30, 2025

  • Add CI workflows.
  • Align Bazel config and deps.
  • Fix build-preventing and other minor issues.

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

MODULE.bazel Outdated
llvm.toolchain(
cxx_standard = {"": "c++17"},
llvm_version = "19.1.0",
register_toolchains(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not register toolchain, use bazelrc.

@arkjedrz arkjedrz force-pushed the arkjedrz_align-repo-state branch from 5c26e3f to 5f7c0c2 Compare December 30, 2025 13:10
@arkjedrz arkjedrz changed the title repo: align repos state infra: add CI workflows Dec 30, 2025
@arkjedrz arkjedrz force-pushed the arkjedrz_align-repo-state branch 2 times, most recently from f88cdbe to 326a14e Compare December 30, 2025 13:16
- name: Run Tests via Bazel
run: |
echo "Running: bazel test //src/..."
bazel test //src/...
Copy link
Contributor

@pawelrutkaq pawelrutkaq Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we have tests in //score ?

@arkjedrz arkjedrz force-pushed the arkjedrz_align-repo-state branch from 326a14e to ed4de84 Compare December 30, 2025 13:29
Copy link

@PiotrKorkus PiotrKorkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bazel build //... doesnt work locally as well

jobs:
build:
name: Build Bazel Code
runs-on: ${{ vars.REPO_RUNNER_LABELS && fromJSON(vars.REPO_RUNNER_LABELS) || 'ubuntu-latest' }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont have self-hosted runners in score, can be just ubuntu-latest

Comment on lines 35 to 39
- name: Install protoc 26.1
uses: arduino/setup-protoc@v3
with:
version: 26.1
repo-token: ${{ secrets.GITHUB_TOKEN }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

step not needed, it works without it

contents: read
pull-requests: read
with:
bazel-target: "//src/..."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about //score/...?

with:
# the bazel-target depends on your repo specific docs_targets configuration (e.g. "suffix")
bazel-target: "//:docs -- --github_user=${{ github.repository_owner }} --github_repo=${{ github.event.repository.name }}"
retention-days: 3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have 3 days here but docs-cleanup.yml runs daily

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checked, those are 2 different things being cleaned. Not valid anymore

jobs:
lint-commits:
name: check-commit-messages
runs-on: ${{ vars.REPO_RUNNER_LABELS && fromJSON(vars.REPO_RUNNER_LABELS) || 'ubuntu-latest' }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-hosted part not needed

run: |
# TODO: restore `//src/...` tests once provided.
# echo "Running: bazel test //src/..."
# bazel test //src/...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for the future it can be merged to single bazel test command - bazel test //src/... //score/...

@arkjedrz arkjedrz self-assigned this Dec 30, 2025
eclipse-otterdog bot and others added 4 commits January 5, 2026 08:23
* Log backend for rust frontend

This is logger impl that bridges rust log frontend
with C++ mw_log implementation

Signed-off-by: Pawel Rutka <pawel.rutka.ext@qorix.ai>

* Adress review findings

* Adapt to cpp/rust structure as in persistency

* Align to baselibs

---------

Signed-off-by: Pawel Rutka <pawel.rutka.ext@qorix.ai>
- Add CI workflows.
- Align Bazel config and deps.
- Fix build-preventing and other minor issues.
@arkjedrz arkjedrz force-pushed the arkjedrz_align-repo-state branch from ed4de84 to fcd11d0 Compare January 5, 2026 08:43
Comment on lines 53 to 57
git_override(
module_name = "score_toolchains_rust",
commit = "bcf8e5364f72cf136ec81960350a82e2b5c45449",
remote = "https://github.com/eclipse-score/toolchains_rust.git",
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be avaliable in v 0.2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@pawelrutkaq pawelrutkaq Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust toolchain is going to change drastically soon. lets leave it as it is for week or two

MODULE.bazel Outdated
bazel_dep(name = "score_toolchains_gcc", version = "0.4", dev_dependency = True)
# S-CORE process rules
bazel_dep(name = "score_bazel_platforms", version = "0.0.3")
bazel_dep(name = "score_docs_as_code", version = "2.0.2")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump to 2.2.0

FScholPer
FScholPer previously approved these changes Jan 5, 2026
Fixes after review.
Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawelrutkaq pawelrutkaq merged commit 5d03b31 into eclipse-score:main Jan 6, 2026
9 checks passed
@arkjedrz arkjedrz deleted the arkjedrz_align-repo-state branch January 6, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants