Replace assert() with baselibs futurecpp assert macros#279
Open
shegazyy wants to merge 1 commit into
Open
Conversation
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
shegazyy
force-pushed
the
fix/replace_assert_with_baselibs_macros
branch
from
2addcde to
958cd87
Compare
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
Replaces all 37 plain assert() calls across 10 source files with the appropriate SCORE_LANGUAGE_FUTURECPP_* macros from score/assert.hpp, as required by project guidelines. Also adds the explicit @score_baselibs//score/language/futurecpp dep to 7 Bazel targets that now directly depend on the assert header. Macro selection follows existing codebase convention: - PRECONDITION[_PRD][_MESSAGE] for constructor/function-entry argument checks - ASSERT_PRD[_MESSAGE] for mid-function invariants in the safety-critical daemon - Default-level PRECONDITION (no PRD) for health_monitor, matching sibling files The _PRD variants guarantee checks survive any future NDEBUG or ASSERT_LEVEL_PRODUCTION build configuration, which is appropriate for the alive_monitor daemon (AUTOSAR PHM code referencing SWS_PHM_00204). Closes eclipse-score#263
shegazyy
force-pushed
the
fix/replace_assert_with_baselibs_macros
branch
from
958cd87 to
12bd5f5
Compare
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces all 37 plain assert() calls across 10 source files with the appropriate SCORE_LANGUAGE_FUTURECPP_* macros from score/assert.hpp, as required by project guidelines. Also adds the explicit @score_baselibs//score/language/futurecpp dep to 7 Bazel targets that now directly depend on the assert header.
Macro selection follows existing codebase convention:
The _PRD variants guarantee checks survive any future NDEBUG or ASSERT_LEVEL_PRODUCTION build configuration, which is appropriate for the alive_monitor daemon (AUTOSAR PHM code referencing SWS_PHM_00204).
Closes #263