Support Reporting Running State and Alive Notifications for applications written in C#270
Open
NicolasFussberger wants to merge 2 commits into
Open
Support Reporting Running State and Alive Notifications for applications written in C#270NicolasFussberger wants to merge 2 commits into
NicolasFussberger wants to merge 2 commits into
Conversation
NicolasFussberger
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
NicolasFussberger
had a problem deploying
to
workflow-approval
GitHub Actions
Error
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
NicolasFussberger
force-pushed
the
feature/support-c-apps
branch
from
35d8612 to
2c2aa11
Compare
NicolasFussberger
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
NicolasFussberger
had a problem deploying
to
workflow-approval
GitHub Actions
Error
NicolasFussberger
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
NicolasFussberger
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
SimonKozik
reviewed
Jul 1, 2026
|
|
||
| void* score_lcm_alive_initialize(const char* instanceSpecifier) noexcept { | ||
| if(instanceSpecifier == nullptr) { | ||
| void* score_lcm_alive_initialize(const char* instanceSpecifier) |
Contributor
There was a problem hiding this comment.
Is there a reason we removed the noexcept?
Contributor
Author
There was a problem hiding this comment.
Its a C-interface, so the noexcept was not valid in C.
Contributor
There was a problem hiding this comment.
Of course stupid question, sorry.
| } | ||
|
|
||
| void score_lcm_alive_deinitialize(void* instance) noexcept { | ||
| void score_lcm_alive_deinitialize(void* instance) |
Contributor
There was a problem hiding this comment.
Is there a reason we removed the noexcept?
This also applies to other functions in this file. Most of them were not even reformatted beyond noexcept removal.
SimonKozik
approved these changes
Jul 1, 2026
paulquiring
reviewed
Jul 1, 2026
| /// it executes the configured recovery action. | ||
| /// | ||
| /// Each process may only use a single Alive instance. | ||
| class Alive |
Contributor
There was a problem hiding this comment.
Suggested change
| class Alive | |
| class Alive final |
paulquiring
reviewed
Jul 1, 2026
| Alive& operator=(Alive&& se) noexcept; | ||
|
|
||
| /// @brief Destructor of an Alive | ||
| virtual ~Alive() noexcept; |
paulquiring
reviewed
Jul 1, 2026
|
|
||
| /// @brief Signals to the Launch Manager that this process has finished initialization and is now running. | ||
| /// @return 0 on success, -1 on failure | ||
| int8_t score_lcm_ReportRunning(void); |
Contributor
There was a problem hiding this comment.
Suggested change
| int8_t score_lcm_ReportRunning(void); | |
| int8_t score_lcm_report_running(void); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we removed the C-prototypes as they were not necessary for C++/rust interaction (rust code has their own function prototypes).
However, this also removed the support for applications written in C, which we otherwise get for free.
This PR adds back the function prototypes and adds an example application written in C that invokes the functions for reporting Running state and Alive Notifications.