-
Notifications
You must be signed in to change notification settings - Fork 25
docs(traceability): align dashboards with coverage metrics #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether its easier / more convenient to extend those diagrams in some clever way. More effort... but otherwise we will always have huge discrepancies between thresholds and dashboards. That sounds like a maintenance nightmare.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea discussed with @MaximilianSoerenPollak. We can probably indeed solve it "like that". This avoids having thresholds and metrics showing different values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay so how to go on then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had the idea to solve it in ref-integration & the consumers.
The integration in re-fint would give you the dashboard for each repo that you wanted.
And the implementation in the consumers (like docs-as-code etc.) would give those repos a statistic as well in their own documentation.
The integration itself would be some thing like a 'generic' needpie function that can be called form the needpie via 'filter-func' attribute.
And then it calculates the things.
This way we have a dashboard and the statistic itself inside the docs therefore do not have risk to show different values.
If you want, we can do this and implement it, or you can give it a go as well. Just let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah but there should be also a dashboard in each of the modules as a must have as they are SEooC. This goes in the same direction as the DR-008
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's why there is a duplication of this.
The code will be in ref-integration and in each of the modules. So they both have these dashboards / statistics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm okay but then is there a way of just link it so that we have it in one central place ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely not as the code that needpie needs to reference hast to be in the same repository.
Though I will see if this is possible to maybe link somehow with a known path etc. If that is possible, then yes this would be the preferred way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to implement that generic filter-func and ping you until its available