Skip to content

fix(docs): queue pending Pages deployments instead of dropping them#132

Merged
AlexanderLanin merged 3 commits into
eclipse-score:mainfrom
qorix-group:dcalavrezo_queue
Jul 1, 2026
Merged

fix(docs): queue pending Pages deployments instead of dropping them#132
AlexanderLanin merged 3 commits into
eclipse-score:mainfrom
qorix-group:dcalavrezo_queue

Conversation

@dcalavrezo-qorix

Copy link
Copy Markdown
Contributor

Add queue: max to the docs-deploy concurrency group so that pending runs are queued rather than skipped.

Add queue: max to the docs-deploy concurrency group so that
pending runs are queued rather than skipped.

Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
AlexanderLanin
AlexanderLanin previously approved these changes Jul 1, 2026

@AlexanderLanin AlexanderLanin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, is it really correct? self check is red, bug in actionlint?

lurtz
lurtz previously approved these changes Jul 1, 2026
@AlexanderLanin

Copy link
Copy Markdown
Member

The pre-commit check fails because actionlint v1.7.11 doesn't know about queue in the concurrency section yet — rhysd/actionlint#654 has the fix but the project appears unmaintained at the moment.

We can suppress this false positive via an actionlint config file. Add .github/actionlint.yml to the repo:

ignore:
  - 'unexpected key "queue" for "concurrency" section'

This ignores exactly this error message (regex match) without disabling any other checks. Once actionlint ships support for queue, the ignore entry can be removed.

actionlint v1.7.11 does not yet recognize the queue key in
concurrency sections. Add .github/actionlint.yml to ignore this
specific error until rhysd/actionlint#654 is merged and released.

Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
@dcalavrezo-qorix dcalavrezo-qorix dismissed stale reviews from lurtz and AlexanderLanin via 1118592 July 1, 2026 11:04
actionlint v1.7.11 does not yet recognize the queue key in
concurrency sections. Add -ignore flag to the pre-commit hook
until rhysd/actionlint#654 is merged and released.

Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
@AlexanderLanin AlexanderLanin changed the title fix(ci): queue pending Pages deployments instead of dropping them fix(docs): queue pending Pages deployments instead of dropping them Jul 1, 2026
@AlexanderLanin

Copy link
Copy Markdown
Member

fix(docs) since docs is the feature here aka reusable workflow

@AlexanderLanin AlexanderLanin merged commit 17318d2 into eclipse-score:main Jul 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants