Fix: add validation for size/offset parameters for various endpoints#1892
Merged
Conversation
…omize constraints for each endpoint and include it in the openapi schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by @autumnfound
There are various endpoints that take a size / offset parameter as input. So far these values were not validated for lower / upper bounds. This PR adds validation in the form:
additionally, for size there is an upper bound check for the following endpoints:
admin endpoints have also been updated with the same validations and with an upper bound of 100.
The reason search / query endpoints have a higher upper bound is because various users use such a value right now and we do not want to break their workflows. 1000 is a reasonable limit but it might be reduced in the future.