refuse a streamed body on a service that also rides the bus - #294
Merged
Merged
Conversation
A streamed answer has no serialization the bus wire can carry; without a guard the declaration compiled and the failure surfaced only when the amqp dispatcher was invoked, as rustc's own trait-bound error naming neither the operation nor the transport nor the reason. The refusal now lands at the seam where transports and bindings are both known, spanned on the operation, combined with the multipart guard's own errors so a service tripping both is told about each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stream sibling of the multipart guard: a
body = "stream"operation on a service also asking foramqp_rpcrefuses at expansion — spanned on the operation, combined with the multipart guard's errors, message naming both ways out. Probe-verified: without the guard the declaration compiles and the failure only appears when the AMQP dispatcher macro is invoked, as an unhelpful double-firedE0277onStreamedAnswer: Serialize. Boundary token-verified: stream-free dual-transport and stream-only http_rest services expand unchanged.Gate:
just lint,just test-named-features(47 doctests incl. the new compile_fail), all-features clippy green.