decode streamed bodies in the typescript client - #293
Merged
Conversation
A streamed operation answers a record of content range and byte stream - undefined at the declared status, the header text at 206, read before the stream is ever named - with header_out composing onto it exactly as bytes composes. The seam response carries a ReadableStream field only where a service declares a stream, the way the request already gates its parts list. The result type stopped naming StreamedAnswer, an identifier no TypeScript surface defines, and renders the same fixed record instead. The readme's coverage paragraph now states the closed gaps truthfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last client-language gap: a
body = "stream"operation in TypeScript answers{ contentRange: string | undefined; body: ReadableStream<Uint8Array> }—contentRangeread at 206 before the stream is named — withheader_outcomposing as on bytes. The seam'sbodyStreamfield is gated on a service declaring a stream, like multipart'sparts. Also fixes the result type emitting the undefined identifierStreamedAnswer(probe-confirmed before fixing): it now renders the same fixed record. README coverage paragraph refreshed to the now-true state.Six new string-level tests; the no-fetch/no-axios assertion stays green. Gate:
just lint,just test-named-features, all-features clippy green.