cover every body kind in the dart http_rest client - #292
Merged
Conversation
The bytes arm returns its composed header_out values instead of dropping them, through the same header-reading helper the json path uses so the two cannot drift. A streamed operation answers a record of content range and byte stream - null at the declared status, the read-back text at 206 - the one shape a Dart record can carry for both streamed answers, named from dart:async alone. A multipart operation builds its parts list from carried fields and part-bound arguments, the file handles crossing as dynamic through the same path an unknown type already renders by. The body-kind matches are exhaustive again and the module doc says so truthfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dart client reaches parity on body kinds. Bytes operations return their composed
header_outvalues through the same header-reading helper the JSON path uses (the two cannot drift). Streamed operations answer({String? contentRange, Stream<List<int>> body})—nullat the declared status, the read-back text at 206 — named fromdart:asyncalone, wrapped in the usual tuple whenheader_outcomposes. Multipart builds its parts list from carried fields pluspart(...)-bound arguments crossing asdynamic. The body-kind matches are exhaustive again.Six new string-level tests over three new fixtures; the 17 existing Dart client tests pass unmodified. Gate:
just lint,just test-named-features, all-features clippy,cargo test --all-featuresall green.