refuse a multipart file part on a service that also rides the bus - #290
Merged
Conversation
A file part arrives as a seam-typed body handle only the http transport can fill; the amqp dispatcher would emit an arm with a parameter nothing on the bus wire can carry. The refusal lands at the seam where the transport list and the parsed bindings are both known, spanned on the operation, naming both ways out. A multipart operation carrying only scalar fields stays legal on a dual-transport service - its fields ride the payload like any json operation, verified by probe before the guard was scoped to file parts alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
part(...)file binding arrives as a seam-typed body handle onlyhttp_restcan fill; a service also asking foramqp_rpcwould emit a bus arm with a parameter nothing on the wire can carry. Refused at expansion — spanned on the operation, errors combined across operations, message naming both ways out — with the verbatim diagnostic captured as a compile_fail doctest. Scalar-only multipart on a dual-transport service stays legal (verified by probe: unbound scalar fields ride the JSON payload exactly like a json operation), so the guard sits exactly on the real failure boundary.Gate:
just lint,just test-named-features, all-features clippy green.