assert the method lookup instead of panicking in the dart client tests - #287
Merged
Conversation
The helper's panic! fails clippy's panic deny under any feature set that compiles the dart-gated test module - a set the default-feature fast gate never builds. The sibling helper's assert-then-unwrap shape is what the lint levels admit; the failure message is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dart client test helper used
unwrap_or_else(|| panic!(...)), which fails-D clippy::panicunder any feature set that compiles the dart-gated test module — a set the default-feature fast gate never builds, so only the periodic powerset caught it. Replaced with the sibling helper's assert-then-unwrap shape; same failure message. Reproduced red on the exact failing combination, green after.