Skip to content

[P2] ffmpeg discovery is Unix-only (which + hardcoded paths); duplicated in two modules #141

Description

@eboudrant

Priority: P2 · Review finding: #15

Both src/video.js and src/imageSlice.js carry their own (slightly diverged) findFfmpeg using which plus Homebrew//usr/bin paths. On Windows, which doesn't exist and the search paths are Unix-only, so ffmpeg is never found even when installed.

Fix: extract a shared src/ffmpeg.js; probe with where on win32 (or just spawnSync('ffmpeg', ['-version'])), and keep one search-path list.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions