Skip to content

[P2] Video export tmpdir leaks if the client disconnects mid-stream #137

Description

@eboudrant

Priority: P2 · Review finding: #11

src/handler.js /api/scans/:id/video cleans the tmpdir on the stream's finish and error events, but not on close — if the client disconnects mid-download, finish never fires and the tmpdir (with the rendered mp4) is leaked.

Fix: also hook res.on('close', ...) (idempotent cleanup), or use stream.pipeline with a finally.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions