Fix: E73 P1.06 pin type#47
Open
alt-0191 wants to merge 1 commit into
Open
Conversation
Author
|
While looking at this symbol, I noticed the nRF52840 VDD pin is also declared as power_in.VDD can act as either a supply input or a regulated output (depending on the power configuration), so it might be more correct to mark it as bidirectional as well. I haven't changed it in this PR, need to discuss before modifying it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin 42 (P1.06) of the nRF52840_E73-2G4M08S1C symbol is incorrectly marked as power_in. It is actually a regular GPIO of the nRF52840, so it should be bidirectional, consistent with the other P0.x / P1.x pins in the same symbol. This avoids false ERC errors.