Conversation
aaryswastaken
requested changes
Mar 18, 2024
aaryswastaken
left a comment
aaryswastaken
left a comment
Member
There was a problem hiding this comment.
You should add headers to your files and update the issue with the room id
| self.packetGenerator = PacketGenerator(self) | ||
|
|
||
| # Start the server | ||
| self.server = Server(FakeConnection(), self) |
Member
There was a problem hiding this comment.
FakeConnection() should be optional and specifiable in the constructor
| self.display.display_error(f"Unexpected error while reading {bytes_to_str(pck)} : {type(e)} {e}") | ||
|
|
||
| def interpret(self, packet: Packet): | ||
| match packet.code: |
Member
There was a problem hiding this comment.
I didnt even knew matches exists
Member
There was a problem hiding this comment.
Will read packet handling later
Member
Author
There was a problem hiding this comment.
Yeah, Python took its time to implement switchs but in the end it made them better than other languages (match can use regex, unpack value from matched value etc...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor yet incomplet.
TODOs :