Skip to content

Ghcw-session-2b16#2

Open
eNipu wants to merge 1 commit intodevfrom
ghcw-session-2b16
Open

Ghcw-session-2b16#2
eNipu wants to merge 1 commit intodevfrom
ghcw-session-2b16

Conversation

@eNipu
Copy link
Copy Markdown
Owner

@eNipu eNipu commented Jun 5, 2025

No description provided.

Copilot AI review requested due to automatic review settings June 5, 2025 13:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CMake configuration by reorganizing the source file groupings and updating the target definitions.

  • Introduces a static library (bls12_lib) for BLS12 source files (excluding main.c)
  • Creates executables directly from main.c files for bls12 and kss16, while removing BN and KSS16 source file lists and their corresponding executables
  • Updates the linking commands to associate the gmp library with both the static library and the executable for bls12
Comments suppressed due to low confidence (1)

CMakeLists.txt:22

  • The BN executable has been removed without an obvious replacement; please confirm that this change aligns with the intended project design and that no BN-related targets or functionality are needed.
Removed: add_executable(bn ${BN_SRC})

target_link_libraries(bls12 gmp)
target_link_libraries(bn gmp)
# Link libraries to executables
target_link_libraries(bls12 bls12_lib gmp)
Copy link

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Linking the 'gmp' library to both the 'bls12' executable and its static library 'bls12_lib' might be redundant; consider consolidating the linking configuration if transitive linking is supported.

Suggested change
target_link_libraries(bls12 bls12_lib gmp)
target_link_libraries(bls12 bls12_lib)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants