Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CMake configuration by reorganizing the source file groupings and updating the target definitions.
- Introduces a static library (bls12_lib) for BLS12 source files (excluding main.c)
- Creates executables directly from main.c files for bls12 and kss16, while removing BN and KSS16 source file lists and their corresponding executables
- Updates the linking commands to associate the gmp library with both the static library and the executable for bls12
Comments suppressed due to low confidence (1)
CMakeLists.txt:22
- The BN executable has been removed without an obvious replacement; please confirm that this change aligns with the intended project design and that no BN-related targets or functionality are needed.
Removed: add_executable(bn ${BN_SRC})
| target_link_libraries(bls12 gmp) | ||
| target_link_libraries(bn gmp) | ||
| # Link libraries to executables | ||
| target_link_libraries(bls12 bls12_lib gmp) |
There was a problem hiding this comment.
[nitpick] Linking the 'gmp' library to both the 'bls12' executable and its static library 'bls12_lib' might be redundant; consider consolidating the linking configuration if transitive linking is supported.
Suggested change
| target_link_libraries(bls12 bls12_lib gmp) | |
| target_link_libraries(bls12 bls12_lib) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.