Skip to content

fix: explicitly import lodash functions from modular packages to avoid potentially bundling the whole lodash #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erengeez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: explicitly import lodash functions from modular packages to avoid potentially bundling the whole lodash #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/ngx-store/src/lib/decorator/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Config, debug } from '../config/config';
import { DecoratorConfig } from '../ngx-store.types';
import { WebStorageServiceInterface } from '../service/webstorage.interface';
import { WebStorageUtility } from '../utility/webstorage.utility';
import { isEqual } from 'lodash';
import isEqual from 'lodash.isequal';

export class CacheItem {
public name: string = '';
Expand Down
4 changes: 3 additions & 1 deletion projects/ngx-store/src/lib/service/resource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { WebStorageService } from "./webstorage.service";
import { Config } from "../config/config";
import { merge, set as lset, get as lget } from "lodash";
import merge from "lodash.merge";
import lset from "lodash.set";
import lget from "lodash.get";

export class Resource<T> {
protected _defaultValue: any = null;
Expand Down
2 changes: 1 addition & 1 deletion projects/ngx-store/src/lib/service/webstorage.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { NgxStorageEvent } from '../utility/storage/storage-event';
import { Resource } from './resource';
import { WebStorageConfigInterface, ClearType } from '../config/config.interface';
import { Config, debug } from '../config/config';
import { merge } from 'lodash';
import merge from 'lodash.merge';

export abstract class WebStorageService {
public static keys: Array<string> = [];
Expand Down